Conversation
Contributor
Summary of ChangesHello @luyi256, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a resource consumption issue in the task scheduler where unfinished tasks would continue to occupy resources even after a batch had met its minimum completion requirements and a grace period. By introducing a dedicated cleanup mechanism, the changes ensure that these lingering tasks are properly terminated and their associated runners are reset, leading to more efficient resource utilization and preventing potential resource leaks. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the logic for cleaning up unfinished tasks in over_rollout scenarios. A new method _cleanup_batch_and_restart_runners is introduced to encapsulate the cleanup logic, which is now called when a batch times out or when the over_rollout condition is met after reaching the minimum number of completed tasks. This fixes an issue where unfinished tasks would continue to consume resources.
My review focuses on improving the robustness of the new cleanup method by handling potential exceptions during runner restarts and ensuring the asynchronous calls are correctly awaited. I've also suggested a minor performance improvement in the get_results method.
Collaborator
Author
|
/unittest-module-common |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
|
/unittest-module-explorer |
pan-x-c
reviewed
Feb 9, 2026
Summary
Tests
Github Test Reporter by CTRF 💚 |
added 2 commits
February 9, 2026 22:46
…led; fix schedule: wait for cleanup if timeout and enabling clear (also for over_rollout)
Collaborator
Author
|
/unittest-module-explorer |
Summary
Tests
Github Test Reporter by CTRF 💚 |
pan-x-c
approved these changes
Feb 11, 2026
chenyushuo
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix over_rollout: clear all the unfinished tasks after finishing the min_num tasks, instead of ignoring these tasks, which will consume resources until they are finished.
Checklist
Please check the following items before code is ready to be reviewed.